Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Japan holidays #2013

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Update Japan holidays #2013

merged 2 commits into from
Sep 23, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Japan holidays:

  • refactor substitute and national holidays calculation
  • add Bank Holiday on Jan 1
  • update tests

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2a7442d) to head (d46c766).
Report is 4 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2013   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       189    +1     
  Lines        11409     11458   +49     
  Branches      1791      1795    +4     
=========================================
+ Hits         11409     11458   +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PPsyrius
PPsyrius reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇯🇵

arkid15r
arkid15r previously approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

holidays/countries/japan.py Outdated Show resolved Hide resolved
@KJhellico @arkid15r
PR suggestion
d46c766 
Co-authored-by: Arkadii Yakovets <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r added this pull request to the merge queue Sep 23, 2024
Merged via the queue into vacanza:dev with commit cb30b0f Sep 23, 2024
32 checks passed
@KJhellico KJhellico deleted the upd-japan branch September 23, 2024 21:32
@arkid15r arkid15r mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PPsyrius PPsyrius PPsyrius left review comments

@arkid15r arkid15r arkid15r approved these changes

Assignees
No one assigned
Labels
snapshot test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KJhellico @arkid15r @PPsyrius